Fixing timing test runner

.gitea/workflows/Benchmark.yaml

@@ -7,7 +7,7 @@ on:
         - 'unit-tests/timing-results/**'
 
 jobs:
-  build_and_test:
+  Benchmarking:
     runs-on: ubuntu-latest
 
     steps:
@@ -28,7 +28,7 @@ jobs:
       - name: Build with Ninja
         run: ninja -C build/
 
-      - name: Run matrix-timing-tests with per-test timing output and save results
+      - name: Run matrix-timing-tests
         run: |
           mkdir -p unit-tests/timing-results
           if [ -x build/unit-tests/matrix-timing-tests ]; then
@@ -39,43 +39,62 @@ jobs:
             echo "matrix-timing-tests executable not found or not executable"
             exit 1
           fi
+
       - name: Compare timing results
         id: check_diff
         run: |
-          # Ensure the previous version exists (from git)
           git show origin/${{ github.event.pull_request.head.ref }}:unit-tests/timing-results/matrix-timing-tests.txt > old.txt || echo "" > old.txt
           cp unit-tests/timing-results/matrix-timing-tests.txt new.txt
 
-          echo "Comparing timing results..."
+          echo "Comparing timing results for changes ≥ 0.1s (ignoring 'Timing Tests' lines)..."
 
-          CHANGED=0
+          changed=0
-          awk '
+
-            BEGIN { change_threshold=0.1 }
+          awk -v changed_ref=/tmp/timings_changed.flag '
-            /^[0-9]+\.[0-9]+ s: / {
+            BEGIN {
-              new_time = $1
+              change_threshold = 0.1
-              label = substr($0, index($0, ":") + 2)
-              if (label_times[label]) {
-                old_time = label_times[label]
-                delta = new_time - old_time
-                if (delta < 0) delta = -delta
-                if (delta >= change_threshold) {
-                  changed = 1
-                }
-              } else {
-                changed = 1
-              }
             }
             FILENAME == "old.txt" && /^[0-9]+\.[0-9]+ s: / {
               label = substr($0, index($0, ":") + 2)
+              if (label != "Timing Tests") {
                 label_times[label] = $1
               }
+            }
+            FILENAME == "new.txt" && /^[0-9]+\.[0-9]+ s: / {
+              new_time = $1
+              label = substr($0, index($0, ":") + 2)
+              if (label == "Timing Tests") next
+
+              old_time = label_times[label]
+              delta = new_time - old_time
+              if (delta < 0) delta = -delta
+
+              if (old_time != "" && delta >= change_threshold) {
+                printf "⚠️  %.3f s → %.3f s: %s (Δ=%.3f s)\n", old_time, new_time, label, delta
+                system("touch " changed_ref)
+              } else if (old_time == "") {
+                printf "🆕 New timing entry: %.3f s: %s\n", new_time, label
+                system("touch " changed_ref)
+              }
+            }
             END {
-              exit changed == 1 ? 0 : 1
+              if (!system("test -f " changed_ref)) {
+                exit 0
+              } else {
+                print "✅ Timings haven’t changed significantly (Δ < 0.1s)."
+                exit 0
+              }
             }
           ' old.txt new.txt
 
+          if [ -f /tmp/timings_changed.flag ]; then
+            echo "timings_changed=true" >> $GITHUB_OUTPUT
+          else
+            echo "timings_changed=false" >> $GITHUB_OUTPUT
+          fi
+
       - name: Commit and push timing results
-        if: steps.check_diff.outcome == 'success' && github.event.pull_request.head.repo.full_name == github.repository
+        if: steps.check_diff.outputs.timings_changed == 'true' && github.event.pull_request.head.repo.full_name == github.repository
         run: |
           git config --global user.name "ci-bot"
           git config --global user.email "ci-bot@local"
@@ -103,6 +122,6 @@ jobs:
           if git diff --quiet --cached; then
             echo "No changes to commit"
           else
-            git commit -m "Update matrix-timing-tests timings [skip ci]"
+            git commit -m "Update matrix-timing-tests timings"
             git push origin "$BRANCH_NAME"
           fi

unit-tests/timing-results/matrix-timing-tests.txt

@@ -3,7 +3,7 @@ Randomness seeded to: 2310772973
 0.174 s: Timing Tests
 0.169 s: Subtraction
 0.169 s: Timing Tests
-1.853 s: Multiplication
+20 s: Multiplication
 1.853 s: Timing Tests
 0.121 s: Scalar Multiplication
 0.121 s: Timing Tests