Cynopolis/Vector3D
1
0
Fork 0
Code Issues 3 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

This is tough
All checks were successful
Merge-Checker / build_and_test (pull_request) Successful in 23s
Details

Browse Source
This commit is contained in:
Quinn
2025-06-05 15:14:45 -04:00
parent d84664b567
commit 4704b8a688
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
unit-tests/matrix-tests.cpp
View File

@@ -539,13 +539,13 @@ TEST_CASE("QR Decompositions", "Matrix") {
} }
// Check that Qᵀ * Q ≈ I // Check that Qᵀ * Q ≈ I
// This MUST be true even if the rank of A is 2 because without this, // Since the rank of this matrix is 2, only the top left 2x2 sub-matrix will
// calculating eigenvalues/vectors will not work. // equal I.
Matrix<3, 3> Qt = Q.Transpose(); Matrix<3, 3> Qt = Q.Transpose();
Matrix<3, 3> QtQ{}; Matrix<3, 3> QtQ{};
QtQ = Qt * Q; QtQ = Qt * Q;
for (int i = 0; i < 3; ++i) { for (int i = 0; i < 2; ++i) {
for (int j = 0; j < 3; ++j) { for (int j = 0; j < 2; ++j) {
if (i == j) if (i == j)
REQUIRE_THAT(QtQ[i][j], Catch::Matchers::WithinRel(1.0f, 1e-4f)); REQUIRE_THAT(QtQ[i][j], Catch::Matchers::WithinRel(1.0f, 1e-4f));
else else